When veryfing a certificate the intermediary subcas #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
force-pushed
the
bugfix/untrusted_car_chain
branch
from
a07452e to
25bb140
Compare
AssemblyJohn
force-pushed
the
bugfix/untrusted_car_chain
branch
from
25bb140 to
c0acda4
Compare
|
Comments were resolved, please re-review. |
…any more Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/untrusted_car_chain
branch
from
c0acda4 to
837d8d3
Compare
|
If everything was resolved, please approve. |
james-ctc
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
There was an issue during certificate verification, that presumed that intermediary certificates presented during either a leaf update or on a car certificate validation were trusted, which is not the case. The function 'x509_verify_certificate_chain' has been updated to reflect the correct functionality.
Issue ticket number and link
Checklist before requesting a review